Skip to content

block API from #35 #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

block API from #35 #39

wants to merge 1 commit into from

Conversation

Gozala
Copy link
Contributor

@Gozala Gozala commented Sep 23, 2020

With 7d2fda3 I have removed block.js from #35, because:

  1. I think Illustrate multiblock encoder/decoder API #38 provides a better alternative.
  2. I did not wanted to block feat: draft for #33 that incorporates feedback #35 until I'd have all the test for block.js.

This pull requests just reverts that removal, so it could be added back or discarded separately.

@Gozala Gozala mentioned this pull request Sep 23, 2020
Merged
@Gozala Gozala closed this Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Gozala